[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

blame -g and authz

From: David Glasser <glasser_at_davidglasser.net>
Date: Thu, 24 Jan 2008 10:58:59 -0800

libsvn_repos/rev_hunt.c(get_path_mergeinfo) calls svn_fs_get_mergeinfo
directly without using the authz wrapper svn_repos_fs_get_mergeinfo.
It is the only place in the code that does. Perhaps in the larger
context of the file this is appropriate, because authz has already
been checked; perhaps it isn't. Hyrum, can you check to make sure
this is valid (I don't understand this code well enough) and if so add
a comment saying "we don't need to do an authz check here because we
already did in function foo"?

--dave

-- 
David Glasser | glasser@davidglasser.net | http://www.davidglasser.net/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-01-24 19:59:14 CET

This is an archived mail posted to the Subversion Dev mailing list.