[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: 'svnsync_tests.py 23 --fs-type bdb' fails due to process abort

From: Malcolm Rowe <malcolm-svn-dev_at_farside.org.uk>
Date: Thu, 24 Jan 2008 17:05:16 +0000

On Wed, Jan 23, 2008 at 05:05:54PM -0500, C. Michael Pilato wrote:
> C. Michael Pilato wrote:
>> C. Michael Pilato wrote:
>>> Specifically in this case, svn_fs_base__dag_commit_txn() (which is
>>> wrapped with a BDB transaction) calls svn_fs_mergeinfo__update_index(),
>>> which in turn calls index_txn_mergeinfo(), which calls (UH-OH!)
>>> svn_fs_revision_root().
>>>
> Oh, geez. I think there are other circular call paths to fix, too, as I
> see the mergeinfo util code also calls svn_fs_node_prop().
>

Doesn't this also break e.g. Cygwin/Windows due to circular linkage
problems? I thought we had to have a strict DAG in library calls, which
means that e.g. libsvn_fs_base can't ever call into libsvn_fs?

Regards,
Malcolm

  • application/pgp-signature attachment: stored
Received on 2008-01-24 18:05:48 CET

This is an archived mail posted to the Subversion Dev mailing list.