[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[PATCH] Broken translation strings since r28979

From: Arfrever Frehtes Taifersar Arahesis <arfrever.fta_at_gmail.com>
Date: Thu, 24 Jan 2008 17:06:23 +0100

2008-01-24 12:49:48 Fabien COELHO napisaƂ(a):
>
> >> Since r28979 several strings are broken in
> >> subversion/libsvn_fs_base/dag.c, e.g.
> >>
> >> _("Invalid value (%" APR_INT64_T_FMT ") for "
> >> "node revision mergeinfo count")
> >>
> >> a #define such as the format cannot be used in in a _() because the
> >> derivation script does not know how to interpret it, and moreover it is
> >> not a constant and may differ from one implementation to another.
> >>
> >> Maybe it should allocate a temporary string with the integer and use a
> >> constant "%s" format.
> >
> > Yes. See r28692.
>
> Sorry for my previous 'ok', I'm not okay:-)
> The problem is still in HEAD

I know.
I only mentioned r28692 as an example of how to fix this bug.

I'm attaching a patch to fix this bug.

[[[
* subversion/libsvn_fs_base/dag.c
  (svn_fs_base__dag_set_mergeinfo_count,
   svn_fs_base__dag_adjust_mergeinfo_count):
* subversion/libsvn_fs_fs/dag.c
  (svn_fs_fs__dag_increment_mergeinfo_count):
   Pass translatable strings to apr_psprintf() function to create intermediate
   strings with appropriate format specifier.

Found by: fabien

Patch by: arfrever
]]]

-- 
Arfrever Frehtes Taifersar Arahesis

Received on 2008-01-24 17:12:43 CET

This is an archived mail posted to the Subversion Dev mailing list.