[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Broken translation strings since r28979

From: Fabien COELHO <fabien.coelho_at_ensmp.fr>
Date: Thu, 24 Jan 2008 12:50:11 +0100 (CET)

>> Since r28979 several strings are broken in
>> subversion/libsvn_fs_base/dag.c, e.g.
>>
>> _("Invalid value (%" APR_INT64_T_FMT ") for "
>> "node revision mergeinfo count")
>>
>> a #define such as the format cannot be used in in a _() because the
>> derivation script does not know how to interpret it, and moreover it is
>> not a constant and may differ from one implementation to another.
>>
>> Maybe it should allocate a temporary string with the integer and use a
>> constant "%s" format.
>
> Yes. See r28692.

Sorry for my previous 'ok', I'm not okay:-)
The problem is still in HEAD :

fabien> svn info subversion/libsvn_fs_base/dag.c
Path: subversion/libsvn_fs_base/dag.c
Name: dag.c
URL:
https://svn.collab.net/repos/svn/trunk/subversion/libsvn_fs_base/dag.c
Repository Root: https://svn.collab.net/repos/svn
Repository UUID: 65390229-12b7-0310-b90b-f21a5aa7ec8e
Revision: 29007
Node Kind: file
Schedule: normal
Last Changed Author: cmpilato
Last Changed Rev: 29005
Last Changed Date: 2008-01-23 19:28:07 +0100 (Wed, 23 Jan 2008)
Text Last Updated: 2008-01-23 19:28:07 +0100 (Wed, 23 Jan 2008)
Checksum: b1a1be768a2f14afea2f27bbb3e83896

fabien> grep FMT subversion/libsvn_fs_base/dag.c
    _("Invalid value (%" APR_INT64_T_FMT ") for "
    _("Invalid value (%" APR_INT64_T_FMT ") for "

fabien> make po-update
../libsvn_fs_base/dag.c:1602: warning: Although being used in a format
string position, the msgid is not a valid C format string. Reason: The
string ends in the middle of a directive.
../libsvn_fs_fs/dag.c:530: warning: Although being used in a format string
position, the msgid is not a valid C format string. Reason: The string
ends in the middle of a directive.
../libsvn_fs_fs/dag.c:539: warning: Although being used in a format string
position, the msgid is not a valid C format string. Reason: The string
ends in the middle of a directive.

-- 
Fabien.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-01-24 12:50:32 CET

This is an archived mail posted to the Subversion Dev mailing list.