[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r28951 - in trunk: notes subversion/include subversion/libsvn_client subversion/svn subversion/tests/cmdline

From: Hyrum K. Wright <hyrum_wright_at_mail.utexas.edu>
Date: Fri, 18 Jan 2008 15:53:47 -0600

cmpilato_at_tigris.org wrote:
> Author: cmpilato
> Date: Fri Jan 18 11:18:53 2008
> New Revision: 28951
>
> Log:
> Finish the --changelist feature revamp for the propset, propget,
> proplist, and propdel subcommands.
>
> * subversion/include/svn_client.h
> (svn_client_propset3, svn_client_propget4, svn_client_proplist3):
> Add 'changelists' parameter.
> (svn_client_propset2, svn_client_propget3, svn_client_proplist2):
> Update docstrings.
...
> Modified: trunk/subversion/include/svn_client.h
> URL: http://svn.collab.net/viewvc/svn/trunk/subversion/include/svn_client.h?pathrev=28951&r1=28950&r2=28951
> ==============================================================================
> --- trunk/subversion/include/svn_client.h (original)
> +++ trunk/subversion/include/svn_client.h Fri Jan 18 11:18:53 2008
> @@ -3154,6 +3154,12 @@
> * SVN_ERR_BAD_MIME_TYPE (if @a propname is "svn:mime-type", but @a
> * propval is not a valid mime-type).
> *
> + * @a changelists is an array of <tt>const char *</tt> changelist
> + * names, used as a restrictive filter on items whose properties are
> + * set; that is, don't set properties on any item unless it's a member
> + * of one of those changelists. If @a changelists is empty (or
> + * altogether @c NULL), no changelist filtering occurs.
> + *
> * If @a ctx->cancel_func is non-NULL, invoke it passing @a
> * ctx->cancel_baton at various places during the operation.
> *
> @@ -3169,14 +3175,16 @@
> svn_depth_t depth,
> svn_boolean_t skip_checks,
> svn_revnum_t base_revision_for_url,
> + const apr_array_header_t *changelists,
> svn_client_ctx_t *ctx,
> apr_pool_t *pool);

<bikeshed color="topaz">
In updating the JavaHL wrappers, I noticed that almost every other
changelist api has the changelist parameter immediately after the depth
parameter, before any boolean flags. Any reason not to do that here?
</bikeshed>

> /**
> * Like svn_client_propset3(), but with @a base_revision_for_url
> - * always @c SVN_INVALID_REVNUM; @a commit_info_p always NULL; and
> - * @a depth set according to @a recurse: if @a recurse is TRUE,
> - * @a depth is @c svn_depth_infinity, else @c svn_depth_empty.
> + * always @c SVN_INVALID_REVNUM; @a commit_info_p always @c NULL; @a
> + * changelists always @c NULL; and @a depth set according to @a
> + * recurse: if @a recurse is TRUE, @a depth is @c svn_depth_infinity,
> + * else @c svn_depth_empty.
> *
> * @deprecated Provided for backward compatibility with the 1.4 API.
> */
> @@ -3262,6 +3270,12 @@
> * and all of its immediate children (both files and directories); if
> * @c svn_depth_infinity, from @a target and everything beneath it.
> *
> + * @a changelists is an array of <tt>const char *</tt> changelist
> + * names, used as a restrictive filter on items whose properties are
> + * set; that is, don't set properties on any item unless it's a member
> + * of one of those changelists. If @a changelists is empty (or
> + * altogether @c NULL), no changelist filtering occurs.
> + *
> * If error, don't touch @a *props, otherwise @a *props is a hash table
> * even if empty.
> *
> @@ -3275,13 +3289,15 @@
> const svn_opt_revision_t *revision,
> svn_revnum_t *actual_revnum,
> svn_depth_t depth,
> + const apr_array_header_t *changelists,
> svn_client_ctx_t *ctx,
> apr_pool_t *pool);
>
> /**
> - * Similar to svn_client_propget4(), but with @a depth set according
> - * to @a recurse: if @a recurse is TRUE, then @a depth is
> - * @c svn_depth_infinity, else @c svn_depth_empty.
> + * Similar to svn_client_propget4(), but with @a changelists passed as
> + * @c NULL, and @a depth set according to @a recurse: if @a recurse is
> + * TRUE, then @a depth is @c svn_depth_infinity, else @c
> + * svn_depth_empty.
> *
> * @deprecated Provided for backward compatibility with the 1.4 API.
> */
> @@ -3374,6 +3390,12 @@
> * equivalent to @c svn_depth_empty. All other values produce undefined
> * results.
> *
> + * @a changelists is an array of <tt>const char *</tt> changelist
> + * names, used as a restrictive filter on items whose properties are
> + * set; that is, don't set properties on any item unless it's a member
> + * of one of those changelists. If @a changelists is empty (or
> + * altogether @c NULL), no changelist filtering occurs.
> + *
> * If @a target is not found, return the error @c SVN_ERR_ENTRY_NOT_FOUND.
> *
> * @since New in 1.5.
> @@ -3383,16 +3405,18 @@
> const svn_opt_revision_t *peg_revision,
> const svn_opt_revision_t *revision,
> svn_depth_t depth,
> + const apr_array_header_t *changelists,
> svn_proplist_receiver_t receiver,
> void *receiver_baton,
> svn_client_ctx_t *ctx,
> apr_pool_t *pool);
...

Received on 2008-01-18 22:54:00 CET

This is an archived mail posted to the Subversion Dev mailing list.