[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: issue-2897 branch work is complete

From: Karl Fogel <kfogel_at_red-bean.com>
Date: Fri, 11 Jan 2008 12:09:24 -0800

Kamesh Jayachandran <kamesh_at_collab.net> writes:
> I am done with issue-2897 branch work.

Congratulations!

> I am leaving to community to decide when to merge that back to trunk.

Kamesh, just to be clear: my concerns about the branch code are merely
that very few people understand it (basically, you and glasser). This
is not your fault, of course. You've been quite responsive to
questions; the real problem has been lack of time for other people to
review & test.

I believe this is the right command to review the branch diff:

   $ svn diff https://svn.collab.net/repos/svn/trunk@28865 \
              https://svn.collab.net/repos/svn/branches/issue-2897

It's 3930 lines (not including test suite changes). That's going to
take some time for people to absorb :-). I'd love to see it merged,
and I hate the fact that you've done all this work only to have people
like me (who didn't have time to review) express a desire for more
review. But, for example, we still don't know for sure whether SQLite
is strictly necessary, and that's a pretty big open question to have.

If the branch diff isn't too complex, that's great; I know that length
doesn't necessarily equal complexity. But remember also that you're
very familiar with this code now: what's simple to you may be complex
to others, at this point.

-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe_at_subversion.tigris.org
For additional commands, e-mail: dev-help_at_subversion.tigris.org
Received on 2008-01-11 18:09:36 CET

This is an archived mail posted to the Subversion Dev mailing list.