Re: Subversion 1.4.6 : 3 tests fail when locale is set to Turkish (tr_TR.UTF-8)

Wednesday 26 December 2007 03:02:48 tarihinde Branko Čibej şunları yazmıştı:
> Peter Samuelson wrote:
> > [Branko Cibej]
> >
> >> else if (strcasecmp(word, "committed") == 0)
> >> {
> >> revision->kind = svn_opt_revision_committed;
> >> }
> >>
> >> The interesting thing to note here is that strcasecmp is in fact doing
> >> the right thing, since "COMMITTED" and "committed" aren't
> >> case-fold-equal in a Turkish locale. I'm not quite sure what to do here.
> >
> > else if (strcasecmp(word, "committed") == 0 ||
> > strcasecmp(word, "COMMITTED") == 0)
> >
> > I know this doesn't technically cover all possible cases, but I believe
> > in practice it would be close enough. It would work for Turkish, and
> > offhand I don't know of other locales that have a similar irregularity
> > with ASCII letters.
>
> Hmm, I almost prefer adding a custom case-fold-compare to svn_string.
> I've got this feeling this is taking too much for granted (apart from
> falling over on edge cases, which I'm not that worried about).

I will look at svn_string and try to come up with a patch.

Regards,
ismail

-- 
Never learn by your mistakes, if you do you may never dare to try again.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org