[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Subversion 1.4.6 : 3 tests fail when locale is set to Turkish (tr_TR.UTF-8)

From: Branko Čibej <brane_at_xbc.nu>
Date: 2007-12-26 02:02:48 CET

Peter Samuelson wrote:
> [Branko Cibej]
>
>> else if (strcasecmp(word, "committed") == 0)
>> {
>> revision->kind = svn_opt_revision_committed;
>> }
>>
>> The interesting thing to note here is that strcasecmp is in fact doing
>> the right thing, since "COMMITTED" and "committed" aren't
>> case-fold-equal in a Turkish locale. I'm not quite sure what to do here.
>>
>
> else if (strcasecmp(word, "committed") == 0 ||
> strcasecmp(word, "COMMITTED") == 0)
>
> I know this doesn't technically cover all possible cases, but I believe
> in practice it would be close enough. It would work for Turkish, and
> offhand I don't know of other locales that have a similar irregularity
> with ASCII letters.
>

Hmm, I almost prefer adding a custom case-fold-compare to svn_string.
I've got this feeling this is taking too much for granted (apart from
falling over on edge cases, which I'm not that worried about).

-- Brane

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Dec 26 02:03:05 2007

This is an archived mail posted to the Subversion Dev mailing list.