[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [Issue 3052] Memory leak in svn.ra.get_log()

From: David James <james_at_cs.toronto.edu>
Date: 2007-12-19 02:26:19 CET

On Dec 18, 2007 3:19 PM, Jelmer Vernooij <jelmer@samba.org> wrote:
> Hi David,
>
> On Tue, Dec 18, 2007 at 11:15:45AM -0800, David James wrote:
> > On Dec 18, 2007 6:18 AM, <jrvernooij@tigris.org> wrote:
> > > It would change the contents of the values changed_path from a class to a tuple.
> > > This means the items of a changed_path element would no longer be accessible by
> > > name and so would break all existing users of that API.
>
> > > It would be nice if somebody familiar with the memory management code in the
> > > Python bindings could have a look at this. I think it's quite easy to fix if you
> > > know your way around.
>
> > How about this (untested) patch instead? From what I can tell it looks
> > like this patch fixes a major memory leak which affects almost all of
> > the SWIG/Python functions, but I don't have an environment setup to
> > compile or test.
>
> Thanks! I can confirm that this patch compiles, that all the Python tests
> still pass with this patch in and that it actually fixes the memory leak. Please
> commit.
>
> Cheers,
>
> Jelmer

Great! Committed in r28544. I also nominated this fix for Subversion
1.4.7 since this fix probably affects every non-trivial script which
uses the Python bindings.

Cheers,

David

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Dec 19 02:26:30 2007

This is an archived mail posted to the Subversion Dev mailing list.