[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [Issue 3052] Memory leak in svn.ra.get_log()

From: David James <james_at_cs.toronto.edu>
Date: 2007-12-18 20:23:04 CET

On Dec 18, 2007 6:18 AM, <jrvernooij@tigris.org> wrote:
> It would change the contents of the values changed_path from a class to a tuple.
> This means the items of a changed_path element would no longer be accessible by
> name and so would break all existing users of that API.
>
> It would be nice if somebody familiar with the memory management code in the
> Python bindings could have a look at this. I think it's quite easy to fix if you
> know your way around.

How about this (untested) patch instead? From what I can tell it looks
like this patch fixes a major memory leak which affects almost all of
the SWIG/Python functions, but I don't have an environment setup to
compile or test.

[[[
Fix major memory leak in Python object duplication code.

* subversion/bindings/swig/python/libsvn_swig_py/swigutil_py.c
  (make_ob_txdelta_window, make_ob_log_changed_path,
   make_ob_wc_status, make_ob_lock, make_ob_auth_ssl_server_cert_info,
   make_ob_info, make_ob_location_segment, make_ob_commit_info,
   make_ob_wc_notify): Fix memory leak.
]]]

Cheers,

David

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Received on Tue Dec 18 20:23:18 2007

This is an archived mail posted to the Subversion Dev mailing list.