[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: static linking broken in trunk since commit of clientstring feature

From: Eric Gillespie <epg_at_pretzelnet.org>
Date: 2007-12-17 19:53:07 CET

"David James" <james@cs.toronto.edu> writes:

> Instead of reverting r28503, why don't you just move
> subversion/libsvn_ra/clientstring.c to subversion/libsvn_subr ? This
> will eliminate the circular dependency. libsvn_subr is a grab bag of
> utilities anyway.
>
> If it turns out later that libsvn_ra_neon and libsvn_ra_serf need to
> share more functions (and not just these two simple functions), we'll
> want to go the whole way and create a "libsvn_ra_util" library,
> similar to libsvn_fs_util. Right now, that seems like overkill though,
> so I think the simple fix above will do.
>
> We can document the above thinking by adding a short comment to the
> top of clientstring.c, so that folks will remember to create a new
> library later if it is needed.
>
> (I've CC'd Max and epg to see if they have better ideas.)

I agree there's no sense creating ra-util just yet. I'll move it today.

-- 
Eric Gillespie <*> epg@pretzelnet.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Dec 17 19:53:18 2007

This is an archived mail posted to the Subversion Dev mailing list.