Hi Stefan,
Instead of reverting r28503, why don't you just move
subversion/libsvn_ra/clientstring.c to subversion/libsvn_subr ? This
will eliminate the circular dependency. libsvn_subr is a grab bag of
utilities anyway.
If it turns out later that libsvn_ra_neon and libsvn_ra_serf need to
share more functions (and not just these two simple functions), we'll
want to go the whole way and create a "libsvn_ra_util" library,
similar to libsvn_fs_util. Right now, that seems like overkill though,
so I think the simple fix above will do.
We can document the above thinking by adding a short comment to the
top of clientstring.c, so that folks will remember to create a new
library later if it is needed.
(I've CC'd Max and epg to see if they have better ideas.)
Cheers,
David
On Dec 17, 2007 7:54 AM, Stefan Sperling <stsp@elego.de> wrote:
> Hi,
>
> linking statically on Linux/BSD seems to have been broken since
> r28503 (custom client string feature):
>
> subversion/libsvn_ra_neon/session.c:831: undefined reference to `svn_ra_get_client_namestring'
>
> "svn log -r28503 | head -n3":
>
> ------------------------------------------------------------------------
> r28503 | epg | 2007-12-15 21:33:37 +0100 (Sat, 15 Dec 2007) | 32 lines
>
> Allow the user-agent string sent over http to be defined by the client.
>
>
> Quoting #svn-dev:
>
> (16:38:34) maxb: Oh, gaaagh
> (16:38:50) maxb: Someone's gone and introduced circular linkage again, haven't they?
> (16:39:09) stsp: it worked last week :)
> (16:39:13) maxb: Yup
> (16:39:16) maxb: Bah
> (16:39:19) sussman [n=sussman@72.14.229.1] entered the room.
> (16:39:19) mode (+o sussman ) by ChanServ
> (16:39:34) stsp: maxb: do you know how to fix this?
> (16:40:10) maxb: Go point out to whoever committed the namestring stuff that circular linkage is not portable, and they need to redesign their patch
> (16:40:28) maxb: And meanwhile, if it's giving other's a pain in development, revert it :-)
> (16:41:30) stsp: can you explain exactly what is circular?
> (16:41:44) stsp: I don't get it :/
> (16:41:52) maxb: libsvn_ra depends on libsvn_ra_neon depends on libsvn_ra
> (16:41:58) maxb: ditto serf
> (16:42:06) stsp: ah, ok
>
>
> Anyone else OK with reverting it?
> Eric, would you be OK with this?
>
> --
> Stefan Sperling <stsp@elego.de> Software Developer
> elego Software Solutions GmbH HRB 77719
> Gustav-Meyer-Allee 25, Gebaeude 12 Tel: +49 30 23 45 86 96
> 13355 Berlin Fax: +49 30 23 45 86 95
> http://www.elego.de Geschaeftsfuehrer: Olaf Wagner
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Dec 17 17:51:02 2007