Re: [PATCH] Fix a compilation failure in Perl bindings

Has anybody had a chance to look at this? Is it still a problem? If I
don't hear anything, I'll open an issue in the issue tracker.

Thanks,
-Hyrum

Arfrever Frehtes Taifersar Arahesis wrote:
> With some settings I'm getting compilation failure in Perl bindings.
>
> cd /var/tmp/portage/dev-util/subversion-1.5_pre27184/work/subversion-1.5_pre27184/subversion/bindings/swig/perl/native; make
> make[1]: Entering directory `/var/tmp/portage/dev-util/subversion-1.5_pre27184/work/subversion-1.5_pre27184/subversion/bindings/swig/perl/native'
> i686-pc-linux-gnu-gcc -c -I/usr/include/apr-1 -I/usr/include/apr-1 -I/usr/include/db4.6 -I../../../../../subversion/bindings/swig/perl/libsvn_swig_perl -I../../../../../subversion/include -I../../../../../subversion -I../../../../../subversion/bindings/swig -g -fno-strict-aliasing -pipe -Wdeclaration-after-statement -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -I/usr/include/gdbm -march=athlon64 -msse3 -pipe -O2 -DVERSION=\"\" -DXS_VERSION=\"\" -fPIC "-I/usr/lib/perl5/5.8.8/i686-linux/CORE" core.c
> In file included from ../../../../../subversion/bindings/swig/perl/libsvn_swig_perl/swigutil_pl.h:38,
> from core.c:1562:
> ../../../../../subversion/svn_private_config.h:156:1: warning: "_" redefined
> In file included from /usr/lib/perl5/5.8.8/i686-linux/CORE/perl.h:37,
> from core.c:703:
> /usr/lib/perl5/5.8.8/i686-linux/CORE/config.h:3808:1: warning: this is the location of the previous definition
> In file included from /usr/include/apr-1/apr_pools.h:38,
> from ../../../../../subversion/include/svn_time.h:26,
> from core.c:1559:
> /usr/include/apr-1/apr.h:284: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘apr_off_t’
> In file included from ../../../../../subversion/include/svn_string.h:72,
> from ../../../../../subversion/include/svn_props.h:31,
> from ../../../../../subversion/include/svn_error_codes.h:49,
> from ../../../../../subversion/include/svn_error.h:49,
> from ../../../../../subversion/include/svn_time.h:29,
> from core.c:1559:
> /usr/include/apr-1/apr_strings.h:299: error: expected declaration specifiers or ‘...’ before ‘apr_off_t’
> /usr/include/apr-1/apr_strings.h:315: error: expected ‘)’ before ‘*’ token
> /usr/include/apr-1/apr_strings.h:351: error: expected ‘)’ before ‘size’
> In file included from /usr/include/apr-1/apr_file_io.h:30,
> from ../../../../../subversion/include/svn_io.h:31,
> from ../../../../../subversion/include/svn_delta.h:36,
> from ../../../../../subversion/bindings/swig/perl/libsvn_swig_perl/swigutil_pl.h:36,
> from core.c:1563:
> /usr/include/apr-1/apr_file_info.h:204: error: expected specifier-qualifier-list before ‘apr_off_t’
> In file included from ../../../../../subversion/include/svn_io.h:31,
> from ../../../../../subversion/include/svn_delta.h:36,
> from ../../../../../subversion/bindings/swig/perl/libsvn_swig_perl/swigutil_pl.h:36,
> from core.c:1563:
> /usr/include/apr-1/apr_file_io.h:632: error: expected declaration specifiers or ‘...’ before ‘apr_off_t’
> /usr/include/apr-1/apr_file_io.h:857: error: expected declaration specifiers or ‘...’ before ‘apr_off_t’
> In file included from ../../../../../subversion/include/svn_delta.h:36,
> from ../../../../../subversion/bindings/swig/perl/libsvn_swig_perl/swigutil_pl.h:36,
> from core.c:1563:
> ../../../../../subversion/include/svn_io.h:1123: error: expected declaration specifiers or ‘...’ before ‘apr_off_t’
> In file included from ../../../../../subversion/include/svn_wc.h:47,
> from ../../../../../subversion/include/svn_client.h:39,
> from ../../../../../subversion/bindings/swig/perl/libsvn_swig_perl/swigutil_pl.h:37,
> from core.c:1563:
> ../../../../../subversion/include/svn_ra.h:181: error: expected ‘)’ before ‘progress’
> ../../../../../subversion/include/svn_ra.h:416: error: expected specifier-qualifier-list before ‘svn_ra_progress_notify_func_t’
> In file included from ../../../../../subversion/include/svn_client.h:39,
> from ../../../../../subversion/bindings/swig/perl/libsvn_swig_perl/swigutil_pl.h:37,
> from core.c:1563:
> ../../../../../subversion/include/svn_wc.h:1721: error: expected specifier-qualifier-list before ‘apr_off_t’
> In file included from ../../../../../subversion/include/svn_client.h:45,
> from ../../../../../subversion/bindings/swig/perl/libsvn_swig_perl/swigutil_pl.h:37,
> from core.c:1563:
> ../../../../../subversion/include/svn_diff.h:221: error: expected declaration specifiers or ‘...’ before ‘apr_off_t’
> ../../../../../subversion/include/svn_diff.h:222: error: expected declaration specifiers or ‘...’ before ‘apr_off_t’
> ../../../../../subversion/include/svn_diff.h:223: error: expected declaration specifiers or ‘...’ before ‘apr_off_t’
> ../../../../../subversion/include/svn_diff.h:224: error: expected declaration specifiers or ‘...’ before ‘apr_off_t’
> ../../../../../subversion/include/svn_diff.h:225: error: expected declaration specifiers or ‘...’ before ‘apr_off_t’
> ...
>
> I have found that it is caused by Makefile.PL.in not respecting CPPFLAGS, while some other files respect CPPFLAGS.
> I'm attaching a patch.
>
> [[[
> Respect CPPFLAGS in Perl bindings.
>
> * subversion/bindings/swig/perl/native/Makefile.PL.in: Set cppflags to CPPFLAGS, and use cppflags in config.
>
> Patch by: arfrever
> ]]]
>
>