[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Fix for reverting broken softlinks

From: David O'Shea <david.oshea_at_s3group.com>
Date: 2007-12-06 12:02:10 CET

On 05/12/2007 23:55, Stefan Sperling wrote:
> On Wed, Nov 28, 2007 at 09:36:25AM +0000, David O'Shea wrote:
>>
>> The diff is against a 1.4.5 tarball, as I cannot check out the trunk
>> from here. I hope this isn't a problem.
>
> It's not a big problem. The diff applies to current trunk with
> a tiny bit of fuzz and one very minor reject.
>
> But for me, the test passes whether or not I patch questions.c with
> your change (on FreeBSD 6.2). This does not seem right.
>
> Can you reproduce this? Could you take a look at the test again
> and verify that it is correct?

Strange. It does fail for me here without the patch. I will check out
the trunk at home tonight and see if I can reproduce it there.

[davidos@willow cmdline]$ ./revert_tests.py --verbose 15
CMD: svnadmin "create" "svn-test-work/local_tmp/repos"
"--bdb-txn-nosync" <TIME = 0.078114>
CMD: svn "import" "--username" "jrandom" "--password" "rayjandom" "-m"
"Log message for revision 1." "svn-test-work/local_tmp/greekfiles"
"file:///local/davidos/svn/subversion-1.4.5/subversion/tests/cmdline/svn-test-work/local_tmp/repos"
"--config-dir"
"/local/davidos/svn/subversion-1.4.5/subversion/tests/cmdline/svn-test-work/local_tmp/config"
<TIME = 0.216879>
CMD: svnadmin "create" "svn-test-work/repositories/revert_tests-15"
"--bdb-txn-nosync" <TIME = 0.066743>
CMD: svnadmin dump "svn-test-work/local_tmp/repos" | svnadmin load
"svn-test-work/repositories/revert_tests-15" <TIME = 0.002003>
CMD: svn "co" "--username" "jrandom" "--password" "rayjandom"
"file:///local/davidos/svn/subversion-1.4.5/subversion/tests/cmdline/svn-test-work/repositories/revert_tests-15"
"svn-test-work/working_copies/revert_tests-15" "--config-dir"
"/local/davidos/svn/subversion-1.4.5/subversion/tests/cmdline/svn-test-work/local_tmp/config"
<TIME = 0.464405>
CMD: svn "add" "svn-test-work/working_copies/revert_tests-15/link"
"--config-dir"
"/local/davidos/svn/subversion-1.4.5/subversion/tests/cmdline/svn-test-work/local_tmp/config"
<TIME = 0.043337>
CMD: svn "commit" "-m" "link"
"svn-test-work/working_copies/revert_tests-15/link" "--config-dir"
"/local/davidos/svn/subversion-1.4.5/subversion/tests/cmdline/svn-test-work/local_tmp/config"
<TIME = 0.947768>
CMD: svn "revert" "svn-test-work/working_copies/revert_tests-15/link"
"--config-dir"
"/local/davidos/svn/subversion-1.4.5/subversion/tests/cmdline/svn-test-work/local_tmp/config"
<TIME = 0.999148>
EXPECTED STDERR:
ACTUAL STDERR:
svn: Can't open file
'svn-test-work/working_copies/revert_tests-15/link': No such file or
directory
EXCEPTION: SVNLineUnequal
FAIL: revert_tests.py 15: revert a broken softlink

-- 
The information contained in this e-mail and in any attachments is confidential and is designated solely for the attention of the intended recipient(s). If you are not an intended recipient, you must not use, disclose, copy, distribute or retain this e-mail or any part thereof. If you have received this e-mail in error, please notify the sender by return e-mail and delete all copies of this e-mail from your computer system(s).
Please direct any additional queries to: communications@s3group.com.
Thank You.
Silicon and Software Systems Limited. Registered in Ireland no. 378073.
Registered Office: South County Business Park, Leopardstown, Dublin 18
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Dec 6 12:02:29 2007

This is an archived mail posted to the Subversion Dev mailing list.