On Wed, Nov 28, 2007 at 09:36:25AM +0000, David O'Shea wrote:
> Hi,
>
> On 23/11/2007 19:37, David Glasser wrote:
> > It looks like a good bug find and fix. Can you write a regression
> > test as well? The connection between the "revert" code and
> > compare_and_verify isn't immediately obvious to me, so a test is
> > especially nice.
>
> I'm attaching an updated patch which contains a new test in revert_tests.py
>
> The diff is against a 1.4.5 tarball, as I cannot check out the trunk
> from here. I hope this isn't a problem.
It's not a big problem. The diff applies to current trunk with
a tiny bit of fuzz and one very minor reject.
But for me, the test passes whether or not I patch questions.c with
your change (on FreeBSD 6.2). This does not seem right.
Can you reproduce this? Could you take a look at the test again
and verify that it is correct?
stsp@ted [cmdline] $ ./revert_tests.py --verbose 19
CMD: svnadmin create svn-test-work/local_tmp/repos --bdb-txn-nosync <TIME = 0.204771>
CMD: svn import -m "Log message for revision 1." svn-test-work/local_tmp/greekfiles file:///home/stsp/elego/svn-tigris/subversion/tests/cmdline/svn-test-work/local_tmp/repos --config-dir /home/stsp/elego/svn-tigris/subversion/tests/cmdline/svn-test-work/local_tmp/config --password rayjandom --no-auth-cache --username jrandom <TIME = 0.298827>
CMD: svnadmin create svn-test-work/repositories/revert_tests-19 --bdb-txn-nosync <TIME = 0.249194>
CMD: svnadmin dump "svn-test-work/local_tmp/repos" | svnadmin load "svn-test-work/repositories/revert_tests-19" --ignore-uuid <TIME = 0.006592>
CMD: svn co file:///home/stsp/elego/svn-tigris/subversion/tests/cmdline/svn-test-work/repositories/revert_tests-19 svn-test-work/working_copies/revert_tests-19 --config-dir /home/stsp/elego/svn-tigris/subversion/tests/cmdline/svn-test-work/local_tmp/config --password rayjandom --no-auth-cache --username jrandom <TIME = 0.490552>
CMD: svn add svn-test-work/working_copies/revert_tests-19/link --config-dir /home/stsp/elego/svn-tigris/subversion/tests/cmdline/svn-test-work/local_tmp/config --password rayjandom --no-auth-cache --username jrandom <TIME = 0.170242>
CMD: svn commit -m link svn-test-work/working_copies/revert_tests-19/link --config-dir /home/stsp/elego/svn-tigris/subversion/tests/cmdline/svn-test-work/local_tmp/config --password rayjandom --no-auth-cache --username jrandom <TIME = 0.230031>
CMD: svn revert svn-test-work/working_copies/revert_tests-19/link --config-dir /home/stsp/elego/svn-tigris/subversion/tests/cmdline/svn-test-work/local_tmp/config --password rayjandom --no-auth-cache --username jrandom <TIME = 0.173965>
PASS: revert_tests.py 19: revert a broken softlink
--
Stefan Sperling <stsp@elego.de> Software Developer
elego Software Solutions GmbH HRB 77719
Gustav-Meyer-Allee 25, Gebaeude 12 Tel: +49 30 23 45 86 96
13355 Berlin Fax: +49 30 23 45 86 95
http://www.elego.de Geschaeftsfuehrer: Olaf Wagner
- application/pgp-signature attachment: stored
Received on Thu Dec 6 00:55:27 2007