Re: [PATCH] hook failure messages

"C. Michael Pilato" <cmpilato@collab.net> writes:

> Not a big fan of this change -- I like seeing the hook name
> (though I find it silly that it is quoted). And the commit
> wasn't blocked by the output, which might be how someone
> interprets "commit blocked with output:".

Well, you're a fan of the idea, I guess, which is what counts :)

> How about one of these:
>
> svn: commit blocked by exit code 1 from pre-commit hook, with output:
> svn: commit blocked by pre-commit hook (exit code 1) with output:

I'll take the second one.

Karl Fogel <kfogel@red-bean.com> writes:

> Regarding the second line: can we get rid of it? Does any user really
> need to see the words "MERGE request" in the context of a commit? :-)

That's an old argument; I stopped complaining ages ago. ra-neon
is always spewing the HTTP request to the user, baffling everyone.
I suppose serf is the same, not sure.

-- 
Eric Gillespie <*> epg@pretzelnet.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org