Re: [PATCH] hook failure messages

Eric Gillespie wrote:
> The hook failure message has always annoyed me. How about this?
> (I'm sure some tests need updating, but I didn't want to get too
> deep if this gets -1'd)
>
> TODAY:
> Transmitting file data .svn: Commit failed (details follow):
> svn: MERGE request failed on '/test/ops'
> svn: 'pre-commit' hook failed (exited with a non-zero exitcode of 1). The follo
> wing error output was produced by the hook:
>
> PROPOSED:
> Transmitting file data .svn: Commit failed (details follow):
> svn: MERGE request failed on '/test/ops'
> svn: commit blocked (exit code 1) with output:

Not a big fan of this change -- I like seeing the hook name (though I find
it silly that it is quoted). And the commit wasn't blocked by the output,
which might be how someone interprets "commit blocked with output:".

How about one of these:

   svn: commit blocked by exit code 1 from pre-commit hook, with output:
   svn: commit blocked by pre-commit hook (exit code 1) with output:

?

-- 
C. Michael Pilato <cmpilato@collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand