[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

[PATCH] [Issue 2662] authz with wildcards

From: Luis Rodrigo Gallardo Cruz <rodrigo_at_nul-unu.com>
Date: 2007-12-01 21:24:55 CET

On Tue, Nov 13, 2007 at 04:55:55PM -0600, Luis Rodrigo Gallardo Cruz wrote:
> I don't yet have something to show, but will post it as soon as I can.

Ok, here's my patch for this issue. There's still at least one problem
with it, but otherwise it's ready and in use in a client's site. The
patch was developed against 1.4.4 but this version is rebased against
trunk revision 28157

I've broken up the patch into 4 pieces to make it easier to understand
and review.

I believe there's no 'natural' way to resolve the conflicts created by
having several globs match a single path, thus we opted for using
"order of declaration" as precedence.

The first part of the patch, record-line-numbers.diff, makes the
config file mechanism record the starting line number of each section,
for use by the rest.

The second patch, non-recursive-wildcards.diff, handles matching
single paths against the globs. I have not tested how this interacts
with the new ~user and aliases syntaxes.

The third patch, recursive-repo-walk.diff, implements walking the repo
when recursive access is requested. *This patch modifies the API,*
because in order to let it walk the repo the callers of
svn_repos_authz_check_access need to provide a svn_fs_root_t*

My patch currently is passing the root for the youngest revision in
the repo. I'm not certain this is the best idea but can't think of a
scenario where it would actually matter.

And, svnserve doesn't work. Aparently I'm not passing the right root,
but I haven't really understood the code enough to tell.

The last part of the patch, wildcards-tests.diff, adds some simple
excercising of the code to the test suite.

The patch set compiles cleanly and the resulting code passes all of
the original test suite + my new tests.

I'll appreciate your reviews and comments.

Received on Sat Dec 1 21:25:17 2007

This is an archived mail posted to the Subversion Dev mailing list.