[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r28102 - trunk/subversion/svnserve

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: 2007-11-28 07:15:12 CET

Karl Fogel wrote:
> cmpilato@tigris.org writes:
>> Fix an annoying insconsistency inside svnserve, where its internal
>> 'fs_path' variable sometimes had a leading slash and sometimes didn't.
>
> (I already propchanged the "insconsistency" above, btw.)
>
>> * subversion/svnserve/server.h
>> (server_baton_t): Note the 'fs_path' always has a leading slash.
>>
>> * subversion/svnserve/serve.c
>> (get_fs_path): Ensure that returned 'fs_path' always has a leading slash.
>> (find_repos): Ensure that baton's 'fs_path' always has a leading slash.
>
> As long as we're here:
>
> * subversion/svnserve/serve.c
> (get_fs_path, find_repos): Ensure that returned 'fs_path' always
> has a leading slash.
>
> ...saves the reader from having to read the same text twice, and
> emphasizes that it's the same change in two places.

But, but ... it's not! One is a returned path, another is a path stuffed
into a baton.

> Ack, this function's doc string was already deficient, but after this
> it became even more so :-). I've updated it in r28105.

Thanks.

-- 
C. Michael Pilato <cmpilato@collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand

Received on Wed Nov 28 07:15:31 2007

This is an archived mail posted to the Subversion Dev mailing list.