[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r28102 - trunk/subversion/svnserve

From: Karl Fogel <kfogel_at_red-bean.com>
Date: 2007-11-28 06:33:02 CET

cmpilato@tigris.org writes:
> Fix an annoying insconsistency inside svnserve, where its internal
> 'fs_path' variable sometimes had a leading slash and sometimes didn't.

(I already propchanged the "insconsistency" above, btw.)

> * subversion/svnserve/server.h
> (server_baton_t): Note the 'fs_path' always has a leading slash.
> * subversion/svnserve/serve.c
> (get_fs_path): Ensure that returned 'fs_path' always has a leading slash.
> (find_repos): Ensure that baton's 'fs_path' always has a leading slash.

As long as we're here:

   * subversion/svnserve/serve.c
     (get_fs_path, find_repos): Ensure that returned 'fs_path' always
       has a leading slash.

...saves the reader from having to read the same text twice, and
emphasizes that it's the same change in two places. I didn't want to
make that major a change to your log message, though, thinking that
perhaps you have some stylistic preference for the way you wrote it,
so I'm just pointing it out here, and waiting to see what you think :-).

> --- trunk/subversion/svnserve/serve.c (original)
> +++ trunk/subversion/svnserve/serve.c Tue Nov 27 21:06:35 2007
> @@ -134,6 +134,9 @@
> "'%s' is not the same repository as '%s'",
> url, repos_url);
> *fs_path = url + len;
> + if (! **fs_path)
> + *fs_path = "/";
> +
> return SVN_NO_ERROR;
> }

Ack, this function's doc string was already deficient, but after this
it became even more so :-). I've updated it in r28105.


To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Nov 28 06:33:12 2007

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.