[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: libsvn_repos: understanding delta.c vs reporter.c

From: Julian Foad <julianfoad_at_btopenworld.com>
Date: 2007-11-26 23:24:30 CET

David Glasser wrote:
> On Nov 22, 2007 5:50 PM, David Glasser <glasser@davidglasser.net> wrote:
>
>>What's up with svn_repos_dir_delta[2] (libsvn_repos/delta.c)? It
>>seems to me like it does a subset of the functionality of the reporter
>>mechanism (libsvn_repos/reporter.c), with a completely duplicated
>>implementation. It also seems like it isn't used much: just in
>>svn_repos_dump_fs2, and in one bit of of the update report in
>>mod_dav_svn. Is its implementation actually semantically different
>>from the implementation of the reporter, or can it be reimplemented as
>>a wrapper around the reporter? Is the separation just for historical
>>reasons?
>
> [...] r8840 explains
> it; the most obvious reason that svn_repos_dir_delta2 can't just be a
> wrapper is that is works on txn roots, but the reporter doesn't.

Reaching this level of awareness can be a big milestone in someone's
understanding of the APIs. Now that you have discovered it, could you add in
the respective API docs at least a hint that a relationship of similarity and
significant differences exists between the two. If you can state some
similarities and differences, so much the better.

The next person along will be grateful.

>>(There are also many places in the code that refer to
>>svn_repos_dir_delta[2] in comments, but which appear to be wrong
>>because it's actually the reporter that implements what it is
>>referring to...)

Urgh.

- Julian

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Nov 26 23:24:46 2007

This is an archived mail posted to the Subversion Dev mailing list.