Re: libsvn_repos: understanding delta.c vs reporter.c

On Nov 22, 2007 5:50 PM, David Glasser <glasser@davidglasser.net> wrote:
> What's up with svn_repos_dir_delta[2] (libsvn_repos/delta.c)? It
> seems to me like it does a subset of the functionality of the reporter
> mechanism (libsvn_repos/reporter.c), with a completely duplicated
> implementation. It also seems like it isn't used much: just in
> svn_repos_dump_fs2, and in one bit of of the update report in
> mod_dav_svn. Is its implementation actually semantically different
> from the implementation of the reporter, or can it be reimplemented as
> a wrapper around the reporter? Is the separation just for historical
> reasons?
>
> (There are also many places in the code that refer to
> svn_repos_dir_delta[2] in comments, but which appear to be wrong
> because it's actually the reporter that implements what it is
> referring to...)

Oh, apparently we have this tool that will tell us the history of our
code base and the rationale for changes in the past. r8840 explains
it; the most obvious reason that svn_repos_dir_delta2 can't just be a
wrapper is that is works on txn roots, but the reporter doesn't.

--dave

-- 
David Glasser | glasser_at_davidglasser.net | http://www.davidglasser.net/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org