[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Fix issue 3026: .svn and _svn silently ignored

From: Augie Fackler <durin42_at_gmail.com>
Date: 2007-11-20 20:31:49 CET

On Nov 20, 2007, at 2:17 PM, Karl Fogel wrote:

> Augie Fackler <durin42@gmail.com> writes:
>> I realized during lunch I forgot to wrap the string in _(), so I
>> fixed
>> that. Updated patch attached.
>
> Attach as mime-type "text/plain" (not "application/octet-stream") so
> we can read it inline in our mailers, please :-).

*stabs Mail.app*

>
>
> The patch is quoted below.
>
>> [[[
>> Fix issue 3026.
>>
>> * subversion/libsvn_subr/opt.c:
>> (svn_opt_args_to_target_array2): Print a message to the user when
>> we ignore a name that's reserved for WC administrative space.
>> ]]]
>
> Whoa -- can't have library functions printing things to stderr or
> stdout (unless doing so is part of the function's job and is so
> described in its documentation). Functions return 'svn_error_t *' for
> a reason :-). So this fix isn't going to be *quite* as simple as
> this...

I thought it seemed too easy - I'll fix this shortly.

> [snip patch]

Thanks!
Augie

>
> Best,
> -Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Nov 20 20:32:43 2007

This is an archived mail posted to the Subversion Dev mailing list.