[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Fix issue 3026: .svn and _svn silently ignored

From: Karl Fogel <kfogel_at_red-bean.com>
Date: 2007-11-20 20:17:44 CET

Augie Fackler <durin42@gmail.com> writes:
> I realized during lunch I forgot to wrap the string in _(), so I fixed
> that. Updated patch attached.

Attach as mime-type "text/plain" (not "application/octet-stream") so
we can read it inline in our mailers, please :-).

The patch is quoted below.

> [[[
> Fix issue 3026.
>
> * subversion/libsvn_subr/opt.c:
> (svn_opt_args_to_target_array2): Print a message to the user when
> we ignore a name that's reserved for WC administrative space.
> ]]]

Whoa -- can't have library functions printing things to stderr or
stdout (unless doing so is part of the function's job and is so
described in its documentation). Functions return 'svn_error_t *' for
a reason :-). So this fix isn't going to be *quite* as simple as
this...

> Index: subversion/libsvn_subr/opt.c
> ===================================================================
> --- subversion/libsvn_subr/opt.c (revision 27918)
> +++ subversion/libsvn_subr/opt.c (working copy)
> @@ -1010,7 +1010,11 @@
> synchronized! */
> if (0 == strcmp(base_name, ".svn")
> || 0 == strcmp(base_name, "_svn"))
> - continue;
> + {
> + SVN_ERR(svn_cmdline_fprintf(stderr, pool, _("Skipping reserved "
> + "file %s\n"), target));
> + continue;
> + }
> }
>
> /* Append the peg revision back to the canonicalized target if

Best,
-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Nov 20 20:24:24 2007

This is an archived mail posted to the Subversion Dev mailing list.