Re: svn commit: r27904 - trunk/subversion/libsvn_ra_serf

On Nov 18, 2007 1:04 PM, Lieven Govaerts <svnlgo@mobsol.be> wrote:
> David Glasser wrote:
> > On Nov 17, 2007 1:22 PM, <lgo@tigris.org> wrote:
> >> Author: lgo
> >> Date: Sat Nov 17 13:22:43 2007
> >> New Revision: 27904
> >>
> >> Log:
> >> Fix a part of copy_tests 58 over ra_serf: On reparent of a ra_serf session,
> >> allocate the new url from the session pool. This avoids segfaults when the pool
> >> passed in to reparent has a shorter lifetime than the session.
> >
> > Good catch! cmpilato and I just tracked down the same bug in ra_svn
> > as well. Have you looked at ra_local or ra_neon?
>
> I'm sure ra_neon uses the session pool too, so that's ok. It looks like
> ra_local uses the pool passed in as argument.
>
> Lieven

Both neon and local do calculations in an argument pool but then copy
into a stringbuf managed by the session pool, so they're OK.

--dave

-- 
David Glasser | glasser_at_davidglasser.net | http://www.davidglasser.net/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org