[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Fix for Issue 2723 (Core Subversion support for programatic diff Index paths)

From: Mark Phippard <markphip_at_gmail.com>
Date: 2007-11-14 22:09:17 CET

On 11/14/07, Jeremy Whitlock <jcscoobyrs@gmail.com> wrote:
> I have just attached the third version of this patch after Dan's
> review. Major changes in the patch are as follows:
> Updated log message format to be more inline with Dan's suggestion.
> Updated core code to remove custom function for path stripping and use
> svn_path_is_child instead.
> Nothing else changed of significance. Below is the url to the patch:
> http://subversion.tigris.org/nonav/issues/showattachment.cgi/795/Issue-2723-3.patch.txt
> Take care,

I applied the patch and ran the JavaHL tests. I then patched
Subclipse to use this feature and tested with Subclipse. It works
properly. There is a separate issue that depth=empty does not work
for files.

I am +1 to commit this patch. I'd prefer to have Dan or someone else
do it since they can review the C code for meeting the project's
standards, working properly etc.

Mark Phippard
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Nov 14 22:09:35 2007

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.