[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r27613 - in branches/issue-2991-dev/subversion: include include/private libsvn_ra_local libsvn_ra_neon libsvn_ra_serf libsvn_ra_svn libsvn_repos mod_dav_svn svnserve tests/cmdline

From: Karl Fogel <kfogel_at_red-bean.com>
Date: 2007-11-12 21:11:26 CET

Karl Fogel <kfogel@red-bean.com> writes:
> "David Glasser" <glasser@davidglasser.net> writes:
>>> --- branches/issue-2991-dev/subversion/libsvn_repos/hooks.c (original)
>>> +++ branches/issue-2991-dev/subversion/libsvn_repos/hooks.c Mon Nov 5 22:20:04 2007
>>> @@ -536,6 +536,7 @@
>>> svn_error_t *
>>> svn_repos__hooks_start_commit(svn_repos_t *repos,
>>> const char *user,
>>> + apr_array_header_t *capabilities,
>>> apr_pool_t *pool)
>>> {
>>> const char *hook = svn_repos_start_commit_hook(repos, pool);
>>> @@ -548,11 +549,15 @@
>>> else if (hook)
>>> {
>>> const char *args[4];
>>> + char *capabilities_string = svn_cstring_join(capabilities, ",", pool);
>>> + /* Get rid of that annoying final comma. */
>>> + capabilities_string[strlen(capabilities_string) - 1] = '\0';
>>
>> I think this overwrites some random bit of memory if the capabilities
>> array is empty.
>
> D'oh, I think you're right; will fix. Thanks, David!

Done in r27772.

-K

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Nov 12 21:11:38 2007

This is an archived mail posted to the Subversion Dev mailing list.