[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r27648 - in trunk/subversion: libsvn_repos svnserve

From: Karl Fogel <kfogel_at_red-bean.com>
Date: 2007-11-12 21:04:26 CET

Karl Fogel <kfogel@red-bean.com> writes:
> "David Glasser" <glasser@davidglasser.net> writes:
>>> --- trunk/subversion/libsvn_repos/repos.h (original)
>>> +++ trunk/subversion/libsvn_repos/repos.h Tue Nov 6 22:00:47 2007
>>> @@ -120,7 +120,13 @@
>>>
>>> /* If non-null, a list of all the capabilities the client (on the
>>> current connection) has self-reported. Each element is a
>>> - 'const char *', one of SVN_RA_CAPABILITY_*. */
>>> + 'const char *', one of SVN_RA_CAPABILITY_*.
>>> +
>>> + Note: it is somewhat counterintuitive that we store the client's
>>> + capabilities, which are session-specific, on the repository
>>> + object. You'd think the capabilities here would represent the
>>> + *repository's* capabilities, but no, they represent the
>>> + client's -- we just don't have any other place to persist them. */
>>> apr_array_header_t *capabilities;
>>
>> Given that it is admittedly counterintuitive, how about calling the
>> field client_capabilities?
>
> +1, will do.

Done in r27771.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Mon Nov 12 21:04:38 2007

This is an archived mail posted to the Subversion Dev mailing list.