Re: svn commit: r27745 - in trunk/subversion: include libsvn_fs_base libsvn_fs_base/bdb

Daniel Rall wrote:
> On Sat, 10 Nov 2007, Vlad Georgescu wrote:
>
>> cmpilato@tigris.org wrote:
>>> Author: cmpilato
>>> Date: Fri Nov 9 12:59:25 2007
>>> New Revision: 27745
>>>
>>> Log:
>>> Add new 'node-origins' table, which is an index mapping node IDs ->
>>> origin node revision IDs, for BDB-backed repositories.
>>> [...]
>>> * subversion/libsvn_fs_base/fs.c
>>> (cleanup_fs): Cleanup the `node-origins' table.
>>> (open_databases): Open (or create) the `node-origins' table.
>>> (base_hotcopy): Copy the `node-origins' table.
>>> [...]
>> This is in base_hotcopy():
>>
>>> @@ -1085,6 +1094,8 @@
>>> "locks", pagesize, pool));
>>> SVN_ERR(copy_db_file_safely(src_path, dest_path,
>>> "lock-tokens", pagesize, pool));
>>> + SVN_ERR(copy_db_file_safely(src_path, dest_path,
>>> + "node-origins", pagesize, pool));
>>>
>> If you hotcopy a repo that doesn't yet have a node-origins table, won't
>> this cause an error?
>
> Yup, unless something creates the node-origins table before
> base_hotcopy() fires (e.g. if opening the database does so).
> svn_io_file_open() will choke opening src_path/"node-origins".

Thanks, guys. I'll look into this.

-- 
C. Michael Pilato <cmpilato@collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand