[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r27745 - in trunk/subversion: include libsvn_fs_base libsvn_fs_base/bdb

From: Daniel Rall <dlr_at_collab.net>
Date: 2007-11-12 19:02:46 CET

On Sat, 10 Nov 2007, Vlad Georgescu wrote:

> cmpilato@tigris.org wrote:
> > Author: cmpilato
> > Date: Fri Nov 9 12:59:25 2007
> > New Revision: 27745
> >
> > Log:
> > Add new 'node-origins' table, which is an index mapping node IDs ->
> > origin node revision IDs, for BDB-backed repositories.
> > [...]
>
> > * subversion/libsvn_fs_base/fs.c
> > (cleanup_fs): Cleanup the `node-origins' table.
> > (open_databases): Open (or create) the `node-origins' table.
> > (base_hotcopy): Copy the `node-origins' table.
> > [...]
>
> This is in base_hotcopy():
>
> > @@ -1085,6 +1094,8 @@
> > "locks", pagesize, pool));
> > SVN_ERR(copy_db_file_safely(src_path, dest_path,
> > "lock-tokens", pagesize, pool));
> > + SVN_ERR(copy_db_file_safely(src_path, dest_path,
> > + "node-origins", pagesize, pool));
> >
>
> If you hotcopy a repo that doesn't yet have a node-origins table, won't
> this cause an error?

Yup, unless something creates the node-origins table before
base_hotcopy() fires (e.g. if opening the database does so).
svn_io_file_open() will choke opening src_path/"node-origins".

  • application/pgp-signature attachment: stored
Received on Mon Nov 12 19:02:56 2007

This is an archived mail posted to the Subversion Dev mailing list.