[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r27741 - in trunk/subversion: include libsvn_fs libsvn_fs_base libsvn_fs_fs tests/libsvn_fs

From: Blair Zajac <blair_at_orcaware.com>
Date: 2007-11-09 19:38:43 CET

cmpilato@tigris.org wrote:
> Author: cmpilato
> Date: Fri Nov 9 08:58:14 2007
> New Revision: 27741
>
> Log:
> Finish issue #3017 by adding a new svn_fs_node_origin_rev() API.
>

> + WARNING: Do *not* call this from inside a trail. */
> +static svn_error_t *
> +prev_location(const char **prev_path,
> + svn_revnum_t *prev_rev,
> + svn_fs_t *fs,
> + svn_fs_root_t *root,
> + const char *path,
> + apr_pool_t *pool)
> +{
> + const char *copy_path, *copy_src_path, *remainder = "";
> + svn_fs_root_t *copy_root;
> + svn_revnum_t copy_src_rev;
> +
> + /* Ask about the most recent copy which affected PATH@REVISION. If
> + there was no such copy, we're done. */
> + SVN_ERR(svn_fs_closest_copy(&copy_root, &copy_path, root, path, pool));

As a style question, if you're in libsvn_fs_base or libsvn_fs_fs, why do you
call back through to svn_fs to call svn_fs_closest_copy and go through the
vtable again?

Blair

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Fri Nov 9 19:38:59 2007

This is an archived mail posted to the Subversion Dev mailing list.