[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Can svn_fs_copy() copy from txn nodes in the same txn?

From: Ph. Marek <philipp.marek_at_bmlv.gv.at>
Date: 2007-11-08 07:05:08 CET

On Mittwoch, 7. November 2007, C. Michael Pilato wrote:
> Blair Zajac wrote:
> > Currently svn_fs_copy() only allows you to copy a node from a revision
> > fs root into a txn fs root.
> >
> > Would it work in the BDB and FSFS backends with no code changes if we
> > allow copies from a txn fs root only if the destination fs root is the
> > same txn as the source fs root?
I'd like to have that, too; in FSVS I'd like to avoid having two revisions for
a (copy, change) operation.

> No.
>
> That's explicitly the case we did *not* want to allow. I don't recall the
> exact details, but doing this means we have to add some additional cycle
> protection logic that currently doesn't exist. I think the problematic
> case is something like:
>
> svn_fs_copy(txn_root, "/some/path", txn_root, "/some/path/under/path");
>
> If the source root is a rev_root, of course, this is totally doable. But
> if the source is a transaction, you've just introduced a cycle into the
> graph.
Would it help if we'd (at least temporarily) put in a check that the source
must be a non-directory, ie. a file or special file?

I think that would at least solve 60% of my usage.

Regards,

Phil

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Nov 8 07:05:22 2007

This is an archived mail posted to the Subversion Dev mailing list.