Re: start-commit.bat

On 11/7/07, D.J. Heap <djheap@gmail.com> wrote:
> On Nov 7, 2007 5:18 PM, Karl Fogel <kfogel@red-bean.com> wrote:
> [snip]
> > Thank you for reporting this.
> >
> > Does anyone know what a portable separator char is? The original
> > issue suggested ";". Maybe I should have done that, but is there
> > anywhere where it causes a problem? What about plain colon ":" ?
>
>
> A comma works fine if the whole list is double-quoted, and we should
> probably be quoting all parameters anyway to handle spaces in paths,
> etc. if APR isn't already.

This behavior disturbs me. It implies that via a careful choice of
username or revprop name or something, Windows hooks can receive
arguments that are shifted one or more spaces.

We should figure out if this causes any serious security problems.

--dave

-- 
David Glasser | glasser_at_davidglasser.net | http://www.davidglasser.net/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org