[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Re: Flushing directory log accumulator during pool cleanup (Re: svn commit: r23342 - trunk/subversion/libsvn_wc)

From: Erik Huelsmann <ehuels_at_gmail.com>
Date: 2007-11-06 21:54:54 CET

On 11/6/07, David Glasser <glasser@davidglasser.net> wrote:
> > I'm happy with the memory/speed tradeoff made by trunk. I don't know
> > for certain what behaviour the existing code has or what behaviour
> > your patch gives. I'd not be happy if after watching 1500
> > notifications "A somefile" scroll past that a failed network
> > connection, or user interrupt, means that those 1500 files vanish.
>
> Philip, I think the follow patch addresses your concern and is also a
> lot simpler than the "keep a boolean" approach I'd suggested before.
> What do you think?

Very nice concept. I thought of this when you mentioned the boolean
the first time, but forgot about it when I didn't respond immediately
but went on to do other things. I think it's best to have a flushable
log_accum and just discard only the 'in-progress' log part. This does
mean we'll need to always write the log on pool cleanup, unless the
log is empty.

bye,

Erik.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Tue Nov 6 21:55:12 2007

This is an archived mail posted to the Subversion Dev mailing list.