[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Update: svnlook diff and whitespace

From: Stefan Sperling <stsp_at_elego.de>
Date: 2007-10-30 22:57:18 CET

On Mon, Oct 22, 2007 at 10:33:14AM -0700, Daniel L. Rall wrote:
> Minor nits:
>
> + const char *extensions; /* diff extension args */ /* UTF-8! */
>
> Those two comments could be collapsed into one.
>
> The endline comment on the decl of txn_name could be put after the ";"
> character.
>
> + svn_string_t *str;
>
> This local variable is declared in two separate stack frames, so that we can
> format a string and appended the formatted value to "header". Could we dump
> the local intermediate var, and use apr_psprintf()/svn_stringbuf_append_cstr()
> instead?

Daniel,

Thanks for your comments.

For some reason I only noticed your mail now that Michael bounced
the thread back to the bottom of my svn-dev mailbox view in mutt.

Sorry :-/

(x-ref to "Issue 2646: Perl bindings" thread:)
You don't seem to be the only one having problem with mail,
and on top of that I am going to switch ISPs soon, too :)

Let's hope email won't fail us again,

-- 
Stefan Sperling <stsp@elego.de>                 Software Developer
elego Software Solutions GmbH                            HRB 77719
Gustav-Meyer-Allee 25, Gebaeude 12        Tel:  +49 30 23 45 86 96 
13355 Berlin                              Fax:  +49 30 23 45 86 95
http://www.elego.de                 Geschaeftsfuehrer: Olaf Wagner

  • application/pgp-signature attachment: stored
Received on Tue Oct 30 22:57:49 2007

This is an archived mail posted to the Subversion Dev mailing list.