[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH-REVIEW] Relative URL support for info command

From: Troy Curtis Jr <troycurtisjr_at_gmail.com>
Date: 2007-10-27 22:21:40 CEST

On 10/27/07, Peter Samuelson <peter@p12n.org> wrote:
> [Troy Curtis Jr]
> > Any and all comments are appreciated!
> I don't have any comments on the patch itself, except to wonder why you
> duplicated the strncmp("^/", path, 2) call.

Blair's relative externals support a couple of different syntax and I
may end up implementing them if I think they are useful. So in that
case the strncmp() call inside svn_path_resolve_relative_url() will be
needed to differentiate between the various forms.

> But I note that your mail
> client labeled the patch as MIME type "Application/octet-stream". It
> is much easier to review and comment on if it is labeled as
> "text/plain" or, indeed, anything beginning with "text/". Many mail
> clients will then let you view the patch inline and quote it in
> replies.
> If you don't know of any better way to control the MIME type of your
> attachments, you can usually convince your mail client to use
> "text/plain" by naming the file something that ends in ".txt".

I didn't notice the octet stream thing until after I sent it. I did
wonder if '.txt' would have solved that issue. Thanks, I'll do that
next time.

> --
> Peter Samuelson | org-tld!p12n!peter | http://p12n.org/
> Version: GnuPG v1.4.6 (GNU/Linux)
> 6Y3TuRj3a/lmtHt8sqxWzZ0=
> =h5ck


"Beware of spyware. If you can, use the Firefox browser." - USA Today
Download now at http://getfirefox.com
Registered Linux User #354814 ( http://counter.li.org/)
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Oct 27 22:22:06 2007

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.