[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH-REVIEW] Relative URL support for info command

From: Peter Samuelson <peter_at_p12n.org>
Date: 2007-10-27 22:05:50 CEST

[Troy Curtis Jr]
> Any and all comments are appreciated!

I don't have any comments on the patch itself, except to wonder why you
duplicated the strncmp("^/", path, 2) call. But I note that your mail
client labeled the patch as MIME type "Application/octet-stream". It
is much easier to review and comment on if it is labeled as
"text/plain" or, indeed, anything beginning with "text/". Many mail
clients will then let you view the patch inline and quote it in

If you don't know of any better way to control the MIME type of your
attachments, you can usually convince your mail client to use
"text/plain" by naming the file something that ends in ".txt".

Peter Samuelson | org-tld!p12n!peter | http://p12n.org/

Received on Sat Oct 27 22:06:03 2007

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.