Re: os.wait in svntest.main.copy_repos?

On 10/17/07, Blair Zajac <blair@orcaware.com> wrote:
> David Glasser wrote:
> > Do we need os.wait()s on the two svnadmin children in
> > svntest.main.copy_repos, like we do in spawn_command? (Would we just
> > call it twice? Or is there some way to get a pid from the popen3 call
> > to wait on that?)
>
> I think we should wait on it.
>
> However, there is no portable way to get the pid from popen3.
>
> On Unix, we get the os.popen3() ends up using the popen2.Popen3 class which has
> a wait() method, but on Windows, popen2.Popen3 is deleted from the module, so
> you can't ask it for it to wait.
>
> Too bad we can't use subprocess since it only comes with Python 2.4 or later, as
> this will make all these issues go away.
>
> We could include a copy of subprocess in our test suite, but I don't know what
> older versions of Python it supports.

I am told that subprocess works with 2.2.

Oh, and also --parallel is broken: it makes a bunch of threads, each
of which call popen3 and then wait, but there's no guarantee that the
test they wait on will be the test they popen3'd.

--dave

-- 
David Glasser | glasser_at_davidglasser.net | http://www.davidglasser.net/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org