[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: os.wait in svntest.main.copy_repos?

From: Blair Zajac <blair_at_orcaware.com>
Date: 2007-10-17 20:11:09 CEST

David Glasser wrote:
> Do we need os.wait()s on the two svnadmin children in
> svntest.main.copy_repos, like we do in spawn_command? (Would we just
> call it twice? Or is there some way to get a pid from the popen3 call
> to wait on that?)

I think we should wait on it.

However, there is no portable way to get the pid from popen3.

On Unix, we get the os.popen3() ends up using the popen2.Popen3 class which has
a wait() method, but on Windows, popen2.Popen3 is deleted from the module, so
you can't ask it for it to wait.

Too bad we can't use subprocess since it only comes with Python 2.4 or later, as
this will make all these issues go away.

We could include a copy of subprocess in our test suite, but I don't know what
older versions of Python it supports.

Blair

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Oct 17 20:11:35 2007

This is an archived mail posted to the Subversion Dev mailing list.