[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r27115 - trunk/subversion/libsvn_client

From: Lieven Govaerts <svnlgo_at_mobsol.be>
Date: 2007-10-11 19:59:52 CEST

Can this segfault be triggered through a normal usage scenario?

Lieven

cmpilato@tigris.org wrote:
> Author: cmpilato
> Date: Thu Oct 11 10:42:33 2007
> New Revision: 27115
>
> Log:
> Fix a SEGFAULT caused by a pool lifetime issue.
>
> * subversion/libsvn_client/update.c
> (file_fetcher): Allocate the file fetcher's session from the right pool.
>
>
> Modified:
> trunk/subversion/libsvn_client/update.c
>
> Modified: trunk/subversion/libsvn_client/update.c
> URL: http://svn.collab.net/viewvc/svn/trunk/subversion/libsvn_client/update.c?pathrev=27115&r1=27114&r2=27115
> ==============================================================================
> --- trunk/subversion/libsvn_client/update.c (original)
> +++ trunk/subversion/libsvn_client/update.c Thu Oct 11 10:42:33 2007
> @@ -70,8 +70,9 @@
> if (! ffb->session)
> SVN_ERR(svn_client__open_ra_session_internal(&(ffb->session),
> ffb->repos_root,
> - NULL, NULL, NULL, FALSE, TRUE,
> - ffb->ctx, pool));
> + NULL, NULL, NULL,
> + FALSE, TRUE,
> + ffb->ctx, ffb->pool));
> SVN_ERR(svn_ra_get_file(ffb->session, path, revision, stream,
> fetched_rev, props, pool));
> return SVN_NO_ERROR;
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: svn-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: svn-help@subversion.tigris.org
>
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Thu Oct 11 19:57:56 2007

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.