Re: svn commit: r26954 - trunk/subversion/mod_dav_svn/reports

On Mon, 08 Oct 2007, Karl Fogel wrote:

> "Hyrum K. Wright" <hyrum_wright@mail.utexas.edu> writes:
> > My relatively simple and incomprehensive testing on the case of plain
> > 'svn up' shows:
> > [08/Oct/2007:13:21:11 -0500] jrandom update '/' r3 unknown
>
> That's all I needed to know, thanks; it looks good.
>
> Would it go against logfile tradition to have the depth field say
> "depth=unknown", "depth=infinity", etc, instead of just being the lone
> word for the depth?
 
A "depth=" prefix would improve the comprehensibility of the log output.

> The other fields kind of explain themselves, but "unknown" could mean
> anything, and it's going to be the common case. (The word "files"
> isn't going to be any more enlightening on its own, for that matter.)
>
> We're about to send a lot of admins scrambling for the reference
> manual every time they parse these logs. We could avoid that...

We'd need to know what to map svn_depth_unknown to on a subcommand-specific
basis.

+1 all around.

-- 
Daniel Rall