> I think the patch has a problem.
>
> The patch uses 64bit version APIs and data structures on X86 too.
The api without the 64 suffix is the old api for 32-bit only systems. Since
dbghelp 5.1 Microsoft implemented these 64 bit api on both 64 and 32 bit
operating systems to allow the same code to work on all their 'current'
operating systems and even documents the old api as only a wrapper around
the new version. (See
http://msdn2.microsoft.com/en-us/library/ms681408.aspx)
The subversion code always checked whether dbghelp.dll has at least version
6.6.7.5 before using any of the dbghelp.dll functions. So this does not
change the outside dependencies for us.
(I wrote about this in my original e-mail)
Bert
> SymGetLineFromAddr64
> StackWalk64
> SymFunctionTableAccess64
> SymGetModuleBase64
> IMAGEHLP_LINE64
> STACKFRAME64
>
> Regards.
> Masaru
>
> 2007/9/29, D.J. Heap <djheap@gmail.com>:
> > On 9/21/07, Bert Huijben <bert@vmoo.com> wrote:
> > > > -----Original Message-----
> > > > From: Bert Huijben [mailto:B.Huijben@competence.biz]
> > > >
> > > > Hi,
> > > >
> > > > The attached patch allows compiling subversion for Win64/x64.
Windows
> > > > defines WIN64 as an extended WIN32, so I had to update the crash
> > > > handler.
> > >
> > > The new attached patch (v02) allows clean compilation on non win64
targets.
> > > (Microsoft typedefed some 32 bit types to the 64 bit versions on 64
bit
> > > builds).
> > >
> >
> >
> > I'll try to get setup to build and test this over the weekend -- if I
> > don't see any issues and no one objects, I'll commit it in a few days.
> >
> > Thanks!
> >
> > DJ
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sat Sep 29 15:50:46 2007