[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: naming issue: SVN_FS_PROP_TXN_*

From: Malcolm Rowe <malcolm-svn-dev_at_farside.org.uk>
Date: 2007-09-19 21:21:58 CEST

On Wed, Sep 19, 2007 at 11:26:20AM -0700, David Glasser wrote:
> Three property names are defined in libsvn_fs/fs-loader.h starting
> with SVN_FS_PROP_TXN_: SVN_FS_PROP_TXN_CHECK_LOCKS,
> SVN_FS_PROP_TXN_CHECK_OOD, and SVN_FS_PROP_TXN_CONTAINS_MERGEINFO.
>
> Shouldn't they be SVN_FS__PROP_TXN_*?
>

No, I think the first two are part of a public API, though I haven't
time to check just now.

> (Also, I don't think contains-mergeinfo is necessary: it's only used

(agreed).

> by FSFS, and you should be able to just see if the mergeinfo file
> exists on disk instead, no?)
>

Sure. I'd actually like to move the mergeinfo information -- currently
stored in a 'mergeinfo transaction property' file -- into the
already-existing transaction properties hash (since I see no reason why
we need a separate file). So we'd need to read that instead, but sure.

Regards,
Malcolm

  • application/pgp-signature attachment: stored
Received on Wed Sep 19 21:22:14 2007

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.