Daniel Rall wrote:
> On Sep 13, 2007, at 10:29 AM, Daniel Rall wrote:
>> On Sep 12, 2007, at 10:48 PM, email@example.com wrote:
>>> Fix random Windows buildbot errors: the tests currently cache the
>>> but when running the tests in parallel you can't rely on them being the
>>> credentials you expect. Solution is to always explicitly pass the
>>> you want to use.
>>> * subversion/tests/cmdline/lock_tests.py
>>> (commit_propchange): specify username and password for the commit.
>>> Modified: trunk/subversion/tests/cmdline/lock_tests.py
>>> --- trunk/subversion/tests/cmdline/lock_tests.py (original)
>>> +++ trunk/subversion/tests/cmdline/lock_tests.py Wed Sep 12
>>> 22:48:21 2007
>>> @@ -181,7 +181,10 @@
>>> # make a property change and commit it, allowing lock to be released
>>> svntest.main.run_svn(None, 'propset', 'blue', 'azul', file_path)
>>> - svntest.main.run_svn(None, 'commit', '-m', '', file_path)
>>> + svntest.main.run_svn(None, 'commit',
>>> + '--username', svntest.main.wc_author,
>>> + '--password', svntest.main.wc_passwd,
>>> + '-m', '', file_path)
>> Is this necessary anywhere that we use run_svn()? I just added more
>> usage of it to actions.py...
> In r26582, I updated my recent changes with those arguments. However,
> should we instead modify run_svn() to add them when they aren't
> specified (or something of the kind)?
That's fine with me. run_svn() would have to scan its arguments to know if
the 'svn' command it was about to run accepts those options (otherwise 'svn'
would error out).
C. Michael Pilato <firstname.lastname@example.org>
CollabNet <> www.collab.net <> Distributed Development On Demand
Received on Thu Sep 13 20:51:51 2007