Re: svn commit: r26533 - in trunk/subversion: include libsvn_client libsvn_subr libsvn_wc

On 9/12/07, Karl Fogel <kfogel@red-bean.com> wrote:
> "Erik Huelsmann" <ehuels@gmail.com> writes:
> > But only slightly: neither one nor the other can be passed to
> > svn_error_clear(); both will cause a SEGFAULT, the former because it's
> > an invalid pointer, the latter because it doesn't have a valid POOL
> > object in the pool field....
>
> But that's okay, we don't ever need to pass it to svn_error_clear().
> In fact, svn_iter_apr_hash() and svn_iter_apr_array() already test
>
> if (err->pool)
>
> before clearing. Which I guess you know, since you wrote it :-).
>
> (And svn_error_clear() could test for err->pool itself, which might
> not be such a bad idea...)
>
I'd like idea to test for err->pool in svn_error_clear(), but we
cannot. err->pool is used for functions like svn_handle_error2().

-- 
Ivan Zhakov
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org