[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r26533 - in trunk/subversion: include libsvn_client libsvn_subr libsvn_wc

From: Karl Fogel <kfogel_at_red-bean.com>
Date: 2007-09-12 11:01:07 CEST

"Erik Huelsmann" <ehuels@gmail.com> writes:
> But only slightly: neither one nor the other can be passed to
> svn_error_clear(); both will cause a SEGFAULT, the former because it's
> an invalid pointer, the latter because it doesn't have a valid POOL
> object in the pool field....

But that's okay, we don't ever need to pass it to svn_error_clear().
In fact, svn_iter_apr_hash() and svn_iter_apr_array() already test

      if (err->pool)

before clearing. Which I guess you know, since you wrote it :-).

(And svn_error_clear() could test for err->pool itself, which might
not be such a bad idea...)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Sep 12 10:57:42 2007

This is an archived mail posted to the Subversion Dev mailing list.