[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Improve consistency of that which dates are marked for localization

From: Arfrever Frehtes Taifersar Arahesis <arfrever.fta_at_gmail.com>
Date: 2007-09-05 18:38:14 CEST

Hash: SHA1

2007-09-05 18:04:47 Malcolm Rowe napisaƂ(a):
> On Wed, Sep 05, 2007 at 05:01:44PM +0200, Arfrever Frehtes Taifersar Arahesis wrote:
> > * subversion/libsvn_diff/diff_file.c
> > (output_unified_default_hdr): Mark a date for localization.
> This is presumably consistent with the behaviour of GNU diff and patch
> -- does GNU diff localise the dates? (and does patch take any notice of
> the date?).

Dates (and every other data after file name) are completely ignored (treated as comments) by `patch`.

> Actually, it looks like the core tools only ever use this directly in one
> place -- in the new conflict callback's diff command. Elsewhere (in
> 'svn diff' and 'svnlook diff') we provide our own (different) labelling.
> (I wonder if the conflict callbacks should be consistent with 'svn
> diff'?)

Current conflict callback's diff format is good, although additional revision number would be useful...
But application of my patch doesn't have any side effects :) .

- --
Arfrever Frehtes Taifersar Arahesis
Version: GnuPG v2.0.6 (GNU/Linux)


To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Wed Sep 5 18:37:47 2007

This is an archived mail posted to the Subversion Dev mailing list.