[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Improve consistency of that which dates are marked for localization

From: Malcolm Rowe <malcolm-svn-dev_at_farside.org.uk>
Date: 2007-09-05 18:05:10 CEST

On Wed, Sep 05, 2007 at 05:01:44PM +0200, Arfrever Frehtes Taifersar Arahesis wrote:
> * subversion/libsvn_diff/diff_file.c
> (output_unified_default_hdr): Mark a date for localization.

This is presumably consistent with the behaviour of GNU diff and patch
-- does GNU diff localise the dates? (and does patch take any notice of
the date?). It's possible that we need to stick with this specific
format.

...

Actually, it looks like the core tools only ever use this directly in one
place -- in the new conflict callback's diff command. Elsewhere (in
'svn diff' and 'svnlook diff') we provide our own (different) labelling.

(I wonder if the conflict callbacks should be consistent with 'svn
diff'?)

> * subversion/svn/list-cmd.c
> (print_dirent): Mark dates for localization.
>

This one is presumably supposed to be consistent with 'ls -l', which does
change its output format according to locale -- so I think this is okay.

Regards,
Malcolm

  • application/pgp-signature attachment: stored
Received on Wed Sep 5 18:02:04 2007

This is an archived mail posted to the Subversion Dev mailing list.