Re: Question about get_merged_path_revisions() in rev_hunt.c

Alexander Sinyushkin <Alexander.Sinyushkin@svnkit.com> writes:
> Well, I expect that when trying to get mergeinfo diff in this function
> we need to obtain mergeinfos for old_path_rev->revnum and
> old_path_rev->revnum - 1, but in the second call to
> svn_repos__get_path_mergeinfo() you pass old_path_rev->path - 1
> instead of old_path_rev->revnum - 1:
>
> SVN_ERR(svn_repos__get_path_mergeinfo(&curr_mergeinfo, repos->fs,
> old_path_rev->path,
> old_path_rev->revnum, subpool));
> SVN_ERR(svn_repos__get_path_mergeinfo(&prev_mergeinfo, repos->fs,
> old_path_rev->path - 1,
> old_path_rev->revnum, subpool));
>
> I do not understand what is the reason for passing old_path_rev->path

Looks like a typo to me. I'll bet it should be this instead:

   old_path_rev->revnum - 1

I'll let someone more familiar with that code confirm this and make
the change, though. (I'll mention it in IRC now.)

Nice catch!

-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Sep 2 17:11:52 2007