[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Question about get_merged_path_revisions() in rev_hunt.c

From: Alexander Sinyushkin <Alexander.Sinyushkin_at_svnkit.com>
Date: 2007-09-02 09:30:00 CEST

Hello devs! Sorry again to bother you, but I've got another question
about the source code. This time it's in rev_hunt.c

get_merged_path_revisions(apr_array_header_t *path_revisions,
                           svn_repos_t *repos,
                           struct path_revision *old_path_rev,
                           svn_repos_authz_func_t authz_read_func,
                           void *authz_read_baton,
                           apr_pool_t *pool)

Well, I expect that when trying to get mergeinfo diff in this function
we need to obtain mergeinfos for old_path_rev->revnum and
old_path_rev->revnum - 1, but in the second call to
svn_repos__get_path_mergeinfo() you pass old_path_rev->path - 1 instead
of old_path_rev->revnum - 1:

   SVN_ERR(svn_repos__get_path_mergeinfo(&curr_mergeinfo, repos->fs,
                                         old_path_rev->revnum, subpool));
   SVN_ERR(svn_repos__get_path_mergeinfo(&prev_mergeinfo, repos->fs,
                                         old_path_rev->path - 1,
                                         old_path_rev->revnum, subpool));

I do not understand what is the reason for passing old_path_rev->path -
1. Again I'm awfully sorry if my question does not make any sense to you .

Alexander Sinyushkin,
TMate Software,
http://svnkit.com/ - Java [Sub]Versioning Library!
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Received on Sun Sep 2 09:27:27 2007

This is an archived mail posted to the Subversion Dev mailing list.